Use evaluate #258

gogonzo · 2025-06-19T05:52:45Z

eval_code caches now outputs of the code in the attr(<code line>, "outputs"). See the tests of get_outputs to see how it works.

- adding get_outputs function

github-actions · 2025-06-19T05:56:03Z

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ---------
R/qenv-c.R                          55       0  100.00%
R/qenv-class.R                      13       0  100.00%
R/qenv-concat.R                      7       0  100.00%
R/qenv-constructor.R                 1       0  100.00%
R/qenv-errors.R                      4       4  0.00%    6-9
R/qenv-eval_code.R                  60       1  98.33%   40
R/qenv-extract.R                    30       0  100.00%
R/qenv-get_code.R                   24       0  100.00%
R/qenv-get_env.R                     3       1  66.67%   27
R/qenv-get_messages.r                5       0  100.00%
R/qenv-get_outputs.R                 6       0  100.00%
R/qenv-get_var.R                    26       0  100.00%
R/qenv-get_warnings.R                5       0  100.00%
R/qenv-join.R                        7       7  0.00%    137-151
R/qenv-length.R                      2       1  50.00%   2
R/qenv-show.R                       29      29  0.00%    19-50
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      247       2  99.19%   160, 258
R/utils.R                           42       0  100.00%
TOTAL                              574      45  92.16%

Diff against main

Filename                         Stmts    Miss  Cover
-----------------------------  -------  ------  --------
R/qenv-class.R                      +1       0  +100.00%
R/qenv-eval_code.R                  -2       0  -0.05%
R/qenv-get_outputs.R                +6       0  +100.00%
R/utils-get_code_dependency.R       +2       0  +0.01%
R/utils.R                          +12       0  +100.00%
TOTAL                              +19       0  +0.27%

Results for commit: d17b8df

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

github-actions · 2025-06-19T05:56:17Z

Unit Tests Summary

1 files 14 suites 5s ⏱️
170 tests 167 ✅ 3 💤 0 ❌
260 runs 257 ✅ 3 💤 0 ❌

Results for commit d17b8df.

♻️ This comment has been updated with latest results.

github-actions · 2025-06-19T05:56:19Z

Unit Test Performance Difference

Test Suite	$Status$	Time on `main`	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
get_outputs	👶		$+0.51$	$+16$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on `main`	$±Time$	Test Case
get_outputs	👶		$+0.05$	explicitly_printed_object_uses_newly_registered_print_method_and_returned_as_console_output_string
get_outputs	👶		$+0.04$	explicitly_printed_objects_are_returned_as_console_output_string_in_a_list
get_outputs	👶		$+0.04$	get_output_implicitly_printed_S4_object_is_returned_asis_in_a_list_and_identical_to_the_one_in_the_environment
get_outputs	👶		$+0.05$	implicitly_printed_list_is_returned_asis_even_if_its_print_is_overridden
get_outputs	👶		$+0.09$	implicitly_printed_objects_are_returned_asis_in_a_list_and_are_identical_to_ones_in_the_environment
get_outputs	👶		$+0.03$	intermediate_plots_are_not_kept
get_outputs	👶		$+0.01$	messages_are_returned_asis_in_a_list
get_outputs	👶		$+0.03$	printed_plots_are_returned_as_recordedplot_in_a_list_1_
get_outputs	👶		$+0.03$	printed_plots_are_returned_as_recordedplot_in_a_list_2_
get_outputs	👶		$+0.02$	prints_inside_for_are_bundled_together
get_outputs	👶		$+0.12$	returns_an_empty_list_if_nothing_is_printed
get_outputs	👶		$+0.02$	warnings_are_returned_asis_in_a_list
qenv_eval_code	💀	$0.02$	$-0.02$	alone_comments_at_the_end_of_the_source_are_considered_as_continuation_of_the_last_call
qenv_eval_code	💀	$0.02$	$-0.02$	comments_alone_are_pasted_to_the_next_following_call_element
qenv_eval_code	💀	$0.01$	$-0.01$	comments_at_the_end_of_src_are_added_to_the_previous_call_element
qenv_eval_code	👶		$+0.01$	object_printed_explicitly_is_stored_as_string_in_the_outputs_attribute_of_a_code_element
qenv_eval_code	👶		$+0.02$	object_printed_implicitly_is_stored_asis_in_the_outputs_attribute_of_a_code_element
qenv_eval_code	👶		$+0.03$	plot_cannot_modified_previous_plots_when_calls_are_seperate
qenv_eval_code	👶		$+0.02$	plot_output_is_stored_as_recordedplot_in_the_outputs_attribute_of_a_code_element

Results for commit b53f9e1

♻️ This comment has been updated with latest results.

R/qenv-eval_code.R

tests/testthat/test-get_outputs.R

R/qenv-get_outputs.R

R/qenv-eval_code.R

- mask environment for qenv - remove semicolon from the code

targets: #258

@gogonzo

@gogonzo This might be a better solution that keeps the override under `evaluate()`, while avoiding changing who the `parent.env` is. That is, we don't need to check the "`grand.parent.env()`"

Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Dawid Kałędkowski <[email protected]>

- make sure get_output is returning the same reference - check addition of print.class

R/qenv-eval_code.R

…d function (#261) ### Changes description - Remove intermediate plots by default - Avoids deprecated function in testthat 3rd edition - Adds some tests - Q: Does the S4 test make sense?

averissimo

💯

Fantastic new feature to qenv()!

Left one last comment about adding the information to vignettes

NEWS.md

Followup to insightsengineering/teal.code#258 - eval_code adds `attr(code, "outputs")` to the `teal_card` but skips the warnings and messages (conditions).

averissimo

💯 Awesome

gogonzo added 3 commits June 18, 2025 15:43

evaluate caches outputs

79279da

WIP

9c1f395

- adding get_outputs function

fix R CMD check

ec49b8d

gogonzo added the core label Jun 19, 2025

gogonzo mentioned this pull request Jun 19, 2025

Use evaluate insightsengineering/teal.reporter#344

Merged

averissimo self-assigned this Jun 23, 2025

averissimo reviewed Jun 23, 2025

View reviewed changes

R/qenv-eval_code.R Outdated Show resolved Hide resolved

tests/testthat/test-get_outputs.R Show resolved Hide resolved

R/qenv-get_outputs.R Outdated Show resolved Hide resolved

R/qenv-get_outputs.R Outdated Show resolved Hide resolved

R/qenv-eval_code.R Outdated Show resolved Hide resolved

- single evaluate::evaluate

004364f

- mask environment for qenv - remove semicolon from the code

averissimo mentioned this pull request Jun 24, 2025

Fix tests in use_evaluate branch #259

Merged

averissimo and others added 7 commits June 25, 2025 10:39

fix: problem with tests during R CMD check

208db3b

Fix tests in use_evaluate branch (#259)

8587ca7

targets: #258

Move library() override back to eval_code() (#260)

0f2861b

@gogonzo This might be a better solution that keeps the override under `evaluate()`, while avoiding changing who the `parent.env` is. That is, we don't need to check the "`grand.parent.env()`"

[skip style] [skip vbump] Restyle files

ab12555

chore: fix test from PR merge

6995ae5

Apply suggestions from code review

f878fed

Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Dawid Kałędkowski <[email protected]>

testing

c26c322

- make sure get_output is returning the same reference - check addition of print.class

averissimo reviewed Jun 25, 2025

View reviewed changes

R/qenv-eval_code.R Show resolved Hide resolved

averissimo added 2 commits June 26, 2025 13:41

Adds some tests to use_evaluate feature branch and avoids deprecate…

4858a08

…d function (#261) ### Changes description - Remove intermediate plots by default - Avoids deprecated function in testthat 3rd edition - Adds some tests - Q: Does the S4 test make sense?

fix: test with S4 method registration

a834e08

averissimo approved these changes Jun 26, 2025

View reviewed changes

NEWS.md Show resolved Hide resolved

vignette

d17b8df

gogonzo added a commit to insightsengineering/teal.reporter that referenced this pull request Jun 26, 2025

Use evaluate (#344)

71c4110

Followup to insightsengineering/teal.code#258 - eval_code adds `attr(code, "outputs")` to the `teal_card` but skips the warnings and messages (conditions).

averissimo approved these changes Jun 30, 2025

View reviewed changes

gogonzo merged commit 155391b into main Jun 30, 2025
30 checks passed

gogonzo deleted the use_evaluate branch June 30, 2025 12:54

github-actions bot locked and limited conversation to collaborators Jun 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Use evaluate #258

Use evaluate #258

Uh oh!

gogonzo commented Jun 19, 2025

Uh oh!

github-actions bot commented Jun 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

averissimo left a comment

Uh oh!

Uh oh!

averissimo left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Use evaluate #258

Use evaluate #258

Uh oh!

Conversation

gogonzo commented Jun 19, 2025

Uh oh!

github-actions bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Diff against main

Uh oh!

github-actions bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests Summary

Uh oh!

github-actions bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Performance Difference

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

averissimo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

averissimo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 19, 2025 •

edited

Loading

github-actions bot commented Jun 19, 2025 •

edited

Loading

github-actions bot commented Jun 19, 2025 •

edited

Loading